Skip to content

fix: stabilize interactive CLI prompts on Windows - #360

Merged
0x76agabond merged 3 commits into
Perfect-Abstractions:mainfrom
0x76agabond:main
Jul 17, 2026
Merged

fix: stabilize interactive CLI prompts on Windows#360
0x76agabond merged 3 commits into
Perfect-Abstractions:mainfrom
0x76agabond:main

Conversation

@0x76agabond

Copy link
Copy Markdown
Collaborator

Summary

Fixes the interactive compose init prompt freeze seen on Windows by using direct Inquirer prompt primitives with known working versions. Also scopes CLI CI installs to the CLI workspace lockfile.

Changes Made

  • Replaced @inquirer/prompts usage with direct prompt primitive imports.
  • Added prompt context cleanup for interactive init prompts.
  • Refreshed the CLI package lock for the prompt dependency change.
  • Added a patch changeset for @perfect-abstractions/compose-cli.
  • Updated CLI workflow installs to use npm ci --workspaces=false.

Checklist

Before submitting this PR, please ensure:

  • Code follows the Solidity feature ban - No inheritance, constructors, modifiers, public/private variables, external library functions, using for directives, or selfdestruct

  • Code follows Design Principles - Readable, uses diamond storage, favors composition over inheritance

  • Code matches the codebase style - Consistent formatting, documentation, and patterns (e.g. ERC20Facet.sol)

  • Code is formatted with forge fmt

  • Existing tests pass - Run tests to be sure existing tests pass.

  • New tests are optional - If you don't provide tests for new functionality or changes then please create a new issue so this can be assigned to someone.

  • All tests pass - Run forge test and ensure everything works

  • Documentation updated - If applicable, update relevant documentation

  • Changesets — If this PR changes publishable packages (src/, cli/), changeset-bot will comment if a release note might be needed. You can add one when convenient or defer to maintainers.

Make sure to follow the contributing guidelines.

Additional Notes

@netlify

netlify Bot commented Jul 17, 2026

Copy link
Copy Markdown

👷 Deploy request for compose-diamonds pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 98edafc

@changeset-bot

changeset-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 98edafc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@perfect-abstractions/compose-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Coverage

Metric Coverage Details
Lines 79% 1560/1983 lines
Functions 92% 445/484 functions
Branches 74% 161/217 branches

Last updated: Fri, 17 Jul 2026 18:14:23 GMT for commit 98edafc

@github-actions

Copy link
Copy Markdown
Contributor

Gas Report

No gas usage changes detected between main and main.

All functions maintain the same gas costs. ✅

Last updated: Fri, 17 Jul 2026 18:14:55 GMT for commit 98edafc

@0x76agabond
0x76agabond merged commit aca45d2 into Perfect-Abstractions:main Jul 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant